Changeset 435 in dev for trunk/abdev/BasicCompiler32/NumOpe.cpp

Timestamp:

Mar 15, 2008, 1:20:13 PM (16 years ago)

Author:

dai_9181

Message:

関数の戻り値の構造体など、一時メモリに保持された構造体のメンバに直接アクセスした場合、その一時メモリの解放が正常に行われないバグを修正（まずは32bit版のみ）

File:

• trunk/abdev/BasicCompiler32/NumOpe.cpp (modified) (16 diffs)

trunk/abdev/BasicCompiler32/NumOpe.cpp

@@ -140 +140 @@
     return true;
 }
-bool TermMemberOpe( const Type &leftType, const Type &baseType, Type &resultType, const char *termFull, const char *termLeft, const char *member, bool &isVariable, RELATIVE_VAR &relativeVar )
+bool TermMemberOpe( const Type &leftType, bool &isNeedHeapFreeStructure, const Type &baseType, Type &resultType, const char *termFull, const char *termLeft, const char *member, bool &isVariable, RELATIVE_VAR &relativeVar )
 {
     const CClass &objClass = leftType.GetClass();
@@ -222 +222 @@
         // メンバが見つかったとき
 
+        if( isNeedHeapFreeStructure )
+        {
+            if( !leftType.IsStruct() )
+            {
+                SetError();
+            }
+
+            // 親となる構造体が一時メモリに存在していた場合、後ほど解放する必要がある
+            compiler.codeGenerator.op_AddNeedFreeTempStructure( useReg );
+            isNeedHeapFreeStructure = false;
+        }
+
         //オブジェクトポインタをecxにコピー
         compiler.codeGenerator.op_mov_RR( REG_ECX, useReg );
@@ -271 +283 @@
                 bool dummyIsVariable;
                 RELATIVE_VAR dummyRelativeVar;
-                TermMemberOpe( leftType, baseType, resultType, termFull, termLeft, methodName, dummyIsVariable, dummyRelativeVar );
+                TermMemberOpe( leftType, isNeedHeapFreeStructure, baseType, resultType, termFull, termLeft, methodName, dummyIsVariable, dummyRelativeVar );
 
                 // 戻り値のオブジェクトインスタンスのインデクサを呼び出す
@@ -278 +290 @@
                 sprintf( temp2, "%s.%s", termLeft, methodName );
                 Type classType = resultType;
-                return TermMemberOpe( classType, baseType, resultType, termFull, temp2, temporary, isVariable, relativeVar );
+                return TermMemberOpe( classType, isNeedHeapFreeStructure, baseType, resultType, termFull, temp2, temporary, isVariable, relativeVar );
             }
 
@@ -336 +348 @@
     return false;
 }
-bool _TermOpe( const char *term, const Type &baseType, Type &resultType, bool &isLiteral, BOOL *pbUseHeap, bool *pIsClassName, bool isProcedureCallOnly, bool &isVariable, RELATIVE_VAR &relativeVar, bool isWriteAccess )
+bool _TermOpe( const char *term, const Type &baseType, Type &resultType, bool &isLiteral, bool &isNeedHeapFreeStructure, bool *pIsClassName, bool isProcedureCallOnly, bool &isVariable, RELATIVE_VAR &relativeVar, bool isWriteAccess )
 {
     char parameter[VN_SIZE];
@@ -377 +389 @@
         }
 
-        if( !TermOpe( termLeft, baseType, leftType, isLiteral, pbUseHeap, &isClassName ) ){
+        if( !TermOpe( termLeft, baseType, leftType, isLiteral, isNeedHeapFreeStructure, &isClassName ) ){
             goto globalArea;
         }
@@ -395 +407 @@
         }
 
-        return TermMemberOpe( leftType, baseType, resultType, termFull, termLeft, member, isVariable, relativeVar );
+        return TermMemberOpe( leftType, isNeedHeapFreeStructure, baseType, resultType, termFull, termLeft, member, isVariable, relativeVar );
     }
 globalArea:
@@ -492 +504 @@
 
 
-            if(resultType.IsStruct()){
+            if(resultType.IsStruct())
+            {
                 //構造体が戻ったときはヒープ領域にインスタンスが格納されている
                 //※後にfreeする必要あり
                 // TODO: 解放はGCに任せる
-                *pbUseHeap = 1;
+                isNeedHeapFreeStructure = true;
             }
 
@@ -603 +616 @@
 
 
-        if(resultType.IsStruct()){
+        if(resultType.IsStruct())
+        {
             //構造体が戻ったときはヒープ領域にインスタンスが格納されている
             //※後にfreeする必要あり
             // TODO: 解放はGCに任せる
-            *pbUseHeap = 1;
+            isNeedHeapFreeStructure = true;
         }
 
@@ -623 +637 @@
 }
 
-bool TermOpe( const char *term, const Type &baseType, Type &resultType, bool &isLiteral, BOOL *pbUseHeap, bool *pIsClassName, bool isProcedureCallOnly, bool isWriteAccess )
+bool TermOpe( const char *term, const Type &baseType, Type &resultType, bool &isLiteral, bool &isNeedHeapFreeStructure, bool *pIsClassName, bool isProcedureCallOnly, bool isWriteAccess )
 {
     RELATIVE_VAR relativeVar;
     bool isVariable = false;
-    bool result = _TermOpe( term, baseType, resultType, isLiteral, pbUseHeap, pIsClassName, isProcedureCallOnly, isVariable, relativeVar, isWriteAccess );
+    bool result = _TermOpe( term, baseType, resultType, isLiteral, isNeedHeapFreeStructure, pIsClassName, isProcedureCallOnly, isVariable, relativeVar, isWriteAccess );
 
     if( isVariable )
@@ -641 +655 @@
 bool TermOpeOnlyVariable( const char *term, Type &resultType, RELATIVE_VAR &relativeVar, bool isWriteAccess )
 {
-    bool isLiteral, isVariable = false;
-    bool result = _TermOpe( term, Type(), resultType, isLiteral, NULL, NULL, false, isVariable, relativeVar, isWriteAccess );
+    bool isLiteral, isVariable = false, isNeedHeapFreeStructure = false;
+    bool result = _TermOpe( term, Type(), resultType, isLiteral, isNeedHeapFreeStructure, NULL, false, isVariable, relativeVar, isWriteAccess );
 
     if( !isVariable )
@@ -823 +837 @@
     bool isNothing_stack[255];
     LONG_PTR index_stack[255];
-    BOOL bUseHeap[255];
+    bool isNeedHeapFreeStructureStack[255];
     _int64 i64data;
     for(i=0,sp=0;i<pnum;i++){
@@ -845 +859 @@
                 else{
                     //オーバーロードされたオペレータを呼び出す
-                    i2=CallOperatorProc(idCalc,baseType,type_stack,index_stack,bUseHeap,sp);
+                    i2=CallOperatorProc(idCalc,baseType,type_stack,index_stack,isNeedHeapFreeStructureStack,sp);
                     if(i2==0){
                         if(idCalc==CALC_EQUAL) lstrcpy(temp2,"==");
@@ -867 +881 @@
                 index_stack[sp]=-1;
                 isNothing_stack[sp] = false;
-                bUseHeap[sp]=0;
+                isNeedHeapFreeStructureStack[sp] = false;
 
                 char *term;
@@ -954 +968 @@
 
                     bool isLiteral;
-                    if( TermOpe( term, baseType, resultType, isLiteral, &bUseHeap[sp] ) ){
+                    if( TermOpe( term, baseType, resultType, isLiteral, isNeedHeapFreeStructureStack[sp] ) ){
                         if(resultType.IsNull()){
                             //戻り値が存在しないとき
@@ -1260 +1274 @@
     }
 
-    if(pbUseHeap) *pbUseHeap=bUseHeap[0];
+    if(pbUseHeap) *pbUseHeap = isNeedHeapFreeStructureStack[0];
 
     resultType.SetType( type_stack[0], index_stack[0] );